Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Pool<T> class, load balancer detection and AsyncOperateWrite #142

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

volgunin-ttd
Copy link

@volgunin-ttd volgunin-ttd commented Dec 20, 2024

This request consists of three changes:

  1. Fix to Pool.PeekFirst function. The current implementation looks for data at wrong location.
  2. Changes to load balancer detection in NodeValidator.ValidateAddress function. The current implementation disables load balance detection for local addresses, but proceeds with it anyway, resulting in failing connections in local test environments.
  3. When AsyncOperateWrite is cloned (happens when the connection is lost), the listener is not copied, resulting in calling thread never be notified about command completion.

@volgunin-ttd volgunin-ttd changed the title Fixes to Pool<T> class and load balancer detection Fixes to Pool<T> class, load balancer detection and AsyncOperateWrite Jan 8, 2025
@shannonklaus shannonklaus changed the base branch from master to stage January 8, 2025 22:04
@shannonklaus shannonklaus merged commit a79c1ef into aerospike:stage Jan 9, 2025
4 of 5 checks passed
@shannonklaus
Copy link
Collaborator

Thank you for your pull request. It will be included in the next release, which is expected to happen by the end of the month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants